github/plane
0
0
Fork 1
mirror of https://github.com/makeplane/plane synced 2025-08-07 19:59:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

[WEB-575] chore: safely re-enable SWR (#3805)

Browse Source 
* safley enable swr and make sure to minimalize re renders

* resolve build errors

* fix dropdowns updation by adding observer
This commit is contained in:
rahulramesha
2024-02-28 15:18:11 +05:30
committed by GitHub
parent bd142989b4
commit 6c70d3854a
49 changed files with 952 additions and 1173 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/components/modules/form.tsx
View File

@@ -2,7 +2,7 @@ import { useEffect } from "react";
import { Controller, useForm } from "react-hook-form";
// components
import { ModuleStatusSelect } from "components/modules";
import { DateRangeDropdown, ProjectDropdown, ProjectMemberDropdown } from "components/dropdowns";
import { DateRangeDropdown, ProjectDropdown, MemberDropdown } from "components/dropdowns";
// ui
import { Button, Input, TextArea } from "@plane/ui";
// helpers
@@ -175,7 +175,7 @@ export const ModuleForm: React.FC<Props> = (props) => {
name="lead_id"
render={({ field: { value, onChange } }) => (
<div className="h-7">
<ProjectMemberDropdown
<MemberDropdown
value={value}
onChange={onChange}
projectId={projectId}
@@ -192,7 +192,7 @@ export const ModuleForm: React.FC<Props> = (props) => {
name="member_ids"
render={({ field: { value, onChange } }) => (
<div className="h-7">
<ProjectMemberDropdown
<MemberDropdown
value={value}
onChange={onChange}
projectId={projectId}

6
web/components/modules/sidebar.tsx
View File

@@ -21,7 +21,7 @@ import useToast from "hooks/use-toast";
import { LinkModal, LinksList, SidebarProgressStats } from "components/core";
import { DeleteModuleModal } from "components/modules";
import ProgressChart from "components/core/sidebar/progress-chart";
import { DateRangeDropdown, ProjectMemberDropdown } from "components/dropdowns";
import { DateRangeDropdown, MemberDropdown } from "components/dropdowns";
// ui
import { CustomMenu, Loader, LayersIcon, CustomSelect, ModuleStatusIcon, UserGroupIcon } from "@plane/ui";
// helpers
@@ -385,7 +385,7 @@ export const ModuleDetailsSidebar: React.FC<Props> = observer((props) => {
name="lead_id"
render={({ field: { value } }) => (
<div className="w-3/5 h-7">
<ProjectMemberDropdown
<MemberDropdown
value={value ?? null}
onChange={(val) => {
submitChanges({ lead_id: val });
@@ -409,7 +409,7 @@ export const ModuleDetailsSidebar: React.FC<Props> = observer((props) => {
name="member_ids"
render={({ field: { value } }) => (
<div className="w-3/5 h-7">
<ProjectMemberDropdown
<MemberDropdown
value={value ?? []}
onChange={(val: string[]) => {
submitChanges({ member_ids: val });