Merge pull request #136 from makeplane/preview

release: Minor UI fixes
This commit is contained in:
sriram veeraghanta
2024-03-01 17:52:51 +05:30
committed by GitHub
9 changed files with 11 additions and 2 deletions

View File

@@ -27,6 +27,7 @@ const CustomMenu = (props: ICustomMenuDropdownProps) => {
noBorder = false,
noChevron = false,
optionsClassName = "",
menuItemsClassName = "",
verticalEllipsis = false,
portalElement,
menuButtonOnClick,
@@ -70,7 +71,7 @@ const CustomMenu = (props: ICustomMenuDropdownProps) => {
useOutsideClickDetector(dropdownRef, closeDropdown);
let menuItems = (
<Menu.Items className="fixed z-10" static>
<Menu.Items className={cn("fixed z-10", menuItemsClassName)} static>
<div
className={cn(
"my-1 overflow-y-scroll rounded-md border-[0.5px] border-custom-border-300 bg-custom-background-100 px-2 py-2.5 text-xs shadow-custom-shadow-rg focus:outline-none min-w-[12rem] whitespace-nowrap",

View File

@@ -24,6 +24,7 @@ export interface ICustomMenuDropdownProps extends IDropdownProps {
noBorder?: boolean;
verticalEllipsis?: boolean;
menuButtonOnClick?: (...args: any) => void;
menuItemsClassName?: string;
onMenuClose?: () => void;
closeOnSelect?: boolean;
portalElement?: Element | null;

View File

@@ -131,6 +131,8 @@ export const InboxIssueActionsHeader: FC<TInboxIssueActionsHeader> = observer((p
const handleInboxIssueNavigation = useCallback(
(direction: "next" | "prev") => {
if (!inboxIssues || !inboxIssueId) return;
const activeElement = document.activeElement as HTMLElement;
if (activeElement && (activeElement.classList.contains("tiptap") || activeElement.id === "title-input")) return;
const nextIssueIndex =
direction === "next"
? (currentIssueIndex + 1) % inboxIssues.length

View File

@@ -74,7 +74,7 @@ export const IssueCommentCreate: FC<TIssueCommentCreate> = (props) => {
return (
<div
onKeyDown={(e) => {
if (e.key === "Enter" && !e.shiftKey && !isEmpty) {
if (e.key === "Enter" && !e.shiftKey && !isEmpty && !isSubmitting) {
handleSubmit(onSubmit)(e);
}
}}

View File

@@ -96,6 +96,7 @@ export const AllIssueQuickActions: React.FC<IQuickActionProps> = observer((props
storeType={EIssuesStoreType.PROJECT}
/>
<CustomMenu
menuItemsClassName="z-[14]"
placement="bottom-start"
customButton={customActionButton}
portalElement={portalElement}

View File

@@ -56,6 +56,7 @@ export const ArchivedIssueQuickActions: React.FC<IQuickActionProps> = (props) =>
onSubmit={handleDelete}
/>
<CustomMenu
menuItemsClassName="z-[14]"
placement="bottom-start"
customButton={customActionButton}
portalElement={portalElement}

View File

@@ -106,6 +106,7 @@ export const CycleIssueQuickActions: React.FC<IQuickActionProps> = observer((pro
storeType={EIssuesStoreType.CYCLE}
/>
<CustomMenu
menuItemsClassName="z-[14]"
placement="bottom-start"
customButton={customActionButton}
portalElement={portalElement}

View File

@@ -106,6 +106,7 @@ export const ModuleIssueQuickActions: React.FC<IQuickActionProps> = observer((pr
storeType={EIssuesStoreType.MODULE}
/>
<CustomMenu
menuItemsClassName="z-[14]"
placement="bottom-start"
customButton={customActionButton}
portalElement={portalElement}

View File

@@ -108,6 +108,7 @@ export const ProjectIssueQuickActions: React.FC<IQuickActionProps> = observer((p
isDraft={isDraftIssue}
/>
<CustomMenu
menuItemsClassName="z-[14]"
placement="bottom-start"
customButton={customActionButton}
portalElement={portalElement}