Compare commits

...

1 Commits

Author SHA1 Message Date
NarayanBavisetti
2de3c38c49 chore: pages custom error codes 2024-06-26 13:17:00 +05:30
4 changed files with 44 additions and 14 deletions

View File

@@ -25,7 +25,7 @@ from plane.app.permissions import (
from plane.app.serializers import (
IssueFlatSerializer,
IssueSerializer,
IssueDetailSerializer
IssueDetailSerializer,
)
from plane.bgtasks.issue_activites_task import issue_activity
from plane.db.models import (
@@ -46,6 +46,7 @@ from plane.utils.paginator import (
GroupedOffsetPaginator,
SubGroupedOffsetPaginator,
)
from plane.utils.error_codes import ERROR_CODES
# Module imports
from .. import BaseViewSet, BaseAPIView
@@ -341,8 +342,10 @@ class BulkArchiveIssuesEndpoint(BaseAPIView):
if issue.state.group not in ["completed", "cancelled"]:
return Response(
{
"error_code": 4091,
"error_message": "INVALID_ARCHIVE_STATE_GROUP"
"error_code": ERROR_CODES[
"INVALID_ARCHIVE_STATE_GROUP"
],
"error_message": "INVALID_ARCHIVE_STATE_GROUP",
},
status=status.HTTP_400_BAD_REQUEST,
)

View File

@@ -21,6 +21,7 @@ from plane.db.models import (
IssueAssignee,
)
from plane.bgtasks.issue_activites_task import issue_activity
from plane.utils.error_codes import ERROR_CODES
class BulkIssueOperationsEndpoint(BaseAPIView):
@@ -59,14 +60,20 @@ class BulkIssueOperationsEndpoint(BaseAPIView):
properties = request.data.get("properties", {})
if properties.get("start_date", False) and properties.get("target_date", False):
if properties.get("start_date", False) and properties.get(
"target_date", False
):
if (
datetime.strptime(properties.get("start_date"), "%Y-%m-%d").date()
> datetime.strptime(properties.get("target_date"), "%Y-%m-%d").date()
datetime.strptime(
properties.get("start_date"), "%Y-%m-%d"
).date()
> datetime.strptime(
properties.get("target_date"), "%Y-%m-%d"
).date()
):
return Response(
{
"error_code": 4100,
"error_code": ERROR_CODES["INVALID_ISSUE_DATES"],
"error_message": "INVALID_ISSUE_DATES",
},
status=status.HTTP_400_BAD_REQUEST,
@@ -124,7 +131,9 @@ class BulkIssueOperationsEndpoint(BaseAPIView):
):
return Response(
{
"error_code": 4101,
"error_code": ERROR_CODES[
"INVALID_ISSUE_START_DATE"
],
"error_message": "INVALID_ISSUE_START_DATE",
},
status=status.HTTP_400_BAD_REQUEST,
@@ -158,7 +167,9 @@ class BulkIssueOperationsEndpoint(BaseAPIView):
):
return Response(
{
"error_code": 4102,
"error_code": ERROR_CODES[
"INVALID_ISSUE_TARGET_DATE"
],
"error_message": "INVALID_ISSUE_TARGET_DATE",
},
status=status.HTTP_400_BAD_REQUEST,

View File

@@ -33,7 +33,7 @@ from plane.db.models import (
ProjectMember,
ProjectPage,
)
from plane.utils.error_codes import ERROR_CODES
# Module imports
from ..base import BaseAPIView, BaseViewSet
@@ -465,14 +465,20 @@ class PagesDescriptionViewSet(BaseViewSet):
if page.is_locked:
return Response(
{"error": "Page is locked"},
status=471,
{
"error_code": ERROR_CODES["PAGE_LOCKED"],
"error_message": "PAGE_LOCKED",
},
status=status.HTTP_400_BAD_REQUEST,
)
if page.archived_at:
return Response(
{"error": "Page is archived"},
status=472,
{
"error_code": ERROR_CODES["PAGE_ARCHIVED"],
"error_message": "PAGE_ARCHIVED",
},
status=status.HTTP_400_BAD_REQUEST,
)
base64_data = request.data.get("description_binary")

View File

@@ -0,0 +1,10 @@
ERROR_CODES = {
# issues
"INVALID_ARCHIVE_STATE_GROUP": 4091,
"INVALID_ISSUE_DATES": 4100,
"INVALID_ISSUE_START_DATE": 4101,
"INVALID_ISSUE_TARGET_DATE": 4102,
# pages
"PAGE_LOCKED": 4701,
"PAGE_ARCHIVED": 4702,
}