github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(chromium): roll Chromium to r722269 (#5289)

Browse Source 
This corresponds to Chromium 80.0.3987.0.

This roll includes:

- Implement support for the new ARIA `generic` role
  https://chromium-review.googlesource.com/c/chromium/src/+/1872305
- Expose button's children to accessibility tree
  https://chromium-review.googlesource.com/c/chromium/src/+/1845810
- Remove `Page.handleFileChooser` from CDP
  https://chromium-review.googlesource.com/c/chromium/src/+/1935410
This commit is contained in:
Mathias Bynens
2020-01-27 14:44:53 +01:00
committed by GitHub
parent 14b2369650
commit 013a86cf28
6 changed files with 43 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test/accessibility.spec.js
View File

@@ -81,7 +81,7 @@ module.exports.addTests = function({testRunner, expect, FFOX}) {
expect(await page.accessibility.snapshot()).toEqual(golden);
});
it('should report uninteresting nodes', async function({page}) {
await page.setContent(`<textarea autofocus>hi</textarea>`);
await page.setContent(`<textarea>hi</textarea>`);
await page.focus('textarea');
const golden = FFOX ? {
role: 'entry',
@@ -100,7 +100,7 @@ module.exports.addTests = function({testRunner, expect, FFOX}) {
focused: true,
multiline: true,
children: [{
role: 'GenericContainer',
role: 'generic',
name: '',
children: [{
role: 'text', name: 'hi'
@@ -182,7 +182,7 @@ module.exports.addTests = function({testRunner, expect, FFOX}) {
name: 'my fake image'
}]
} : {
role: 'GenericContainer',
role: 'generic',
name: '',
value: 'Edit this image: ',
children: [{
@@ -241,7 +241,7 @@ module.exports.addTests = function({testRunner, expect, FFOX}) {
<div contenteditable="plaintext-only">Edit this image:<img src="fakeimage.png" alt="my fake image"></div>`);
const snapshot = await page.accessibility.snapshot();
expect(snapshot.children[0]).toEqual({
role: 'GenericContainer',
role: 'generic',
name: ''
});
});
@@ -250,7 +250,7 @@ module.exports.addTests = function({testRunner, expect, FFOX}) {
<div contenteditable="plaintext-only" tabIndex=0>Edit this image:<img src="fakeimage.png" alt="my fake image"></div>`);
const snapshot = await page.accessibility.snapshot();
expect(snapshot.children[0]).toEqual({
role: 'GenericContainer',
role: 'generic',
name: ''
});
});
@@ -360,10 +360,18 @@ module.exports.addTests = function({testRunner, expect, FFOX}) {
const div = await page.$('div');
expect(await page.accessibility.snapshot({root: div})).toEqual(null);
expect(await page.accessibility.snapshot({root: div, interestingOnly: false})).toEqual({
role: 'GenericContainer',
role: 'generic',
name: '',
children: [ { role: 'button', name: 'My Button' } ] }
);
children: [
{
role: 'button',
name: 'My Button',
children: [
{ role: 'text', name: 'My Button' },
],
},
],
});
});
});
});

16
test/chromiumonly.spec.js
View File

@@ -94,22 +94,6 @@ module.exports.addLauncherTests = function({testRunner, expect, defaultBrowserOp
});
});
describe('Page.waitForFileChooser', () => {
it('should fail gracefully when trying to work with filechoosers within multiple connections', async() => {
// 1. Launch a browser and connect to all pages.
const originalBrowser = await puppeteer.launch(defaultBrowserOptions);
await originalBrowser.pages();
// 2. Connect a remote browser and connect to first page.
const remoteBrowser = await puppeteer.connect({browserWSEndpoint: originalBrowser.wsEndpoint()});
const [page] = await remoteBrowser.pages();
// 3. Make sure |page.waitForFileChooser()| does not work with multiclient.
let error = null;
await page.waitForFileChooser().catch(e => error = e);
expect(error.message).toBe('File chooser handling does not work with multiple connections to the same page');
originalBrowser.close();
});
});
});
};