github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: refactor utils.waitForEvents into utils.waitEvent (#2336)

Browse Source 
This simplifies waiting for events in tests.
This commit is contained in:
Andrey Lushnikov
2018-04-09 15:46:05 -07:00
committed by GitHub
parent c86c12e605
commit 06d61919ef
6 changed files with 30 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test/utils.js
View File

@@ -76,22 +76,10 @@ const utils = module.exports = {
/**
* @param {!EventEmitter} emitter
* @param {string} eventName
* @param {number=} eventCount
* @return {!Promise<!Object>}
*/
waitForEvents: function(emitter, eventName, eventCount = 1) {
let fulfill;
const promise = new Promise(x => fulfill = x);
emitter.on(eventName, onEvent);
return promise;
function onEvent(event) {
--eventCount;
if (eventCount)
return;
emitter.removeListener(eventName, onEvent);
fulfill(event);
}
waitEvent: function(emitter, eventName) {
return new Promise(fulfill => emitter.once(eventName, fulfill));
},
/**