Do not leave dangling promises when sending messages over protocol (#742)

It's very bad to have 'unhandled promise rejection' that can't be
handled in user code. These errors will exit node process in a near
future.

This patch avoids 'unhandled promise rejection' while sending protocol
messages.

This patch:
- introduces `puppeteer:error` debug scope and starts using it for all
  swalloed errors.
- makes sure that every `client.send` method is either awaited or its
  errors are handled.
- starts return promises from Request.continue() and Request.abort().
- starts swallow errors from Request.contine() and Request.abort().

The last is the most important part of the patch. Since
`Request.continue()` might try to continue canceled request, we should
disregard the error.

Fixes #627.
This commit is contained in:
Andrey Lushnikov
2017-09-11 16:21:51 -07:00
committed by GitHub
parent f11e09d0d4
commit 0bea42bd8c
14 changed files with 61 additions and 29 deletions

View File

@@ -22,7 +22,7 @@ const Connection = require('./Connection');
const Browser = require('./Browser');
const readline = require('readline');
const fs = require('fs');
const helper = require('./helper');
const {helper} = require('./helper');
const ChromiumRevision = require('../package.json').puppeteer.chromium_revision;
const CHROME_PROFILE_PATH = path.join(os.tmpdir(), 'puppeteer_dev_profile-');