feat(launcher): add browserUrl option to puppeteer.connect (#3558)

The `browserURL` option allows to connect to a browser that exposed it's remote debugging protocol on a known port.

Fixes #3537
This commit is contained in:
Łukasz Fiszer
2019-01-14 22:23:34 +01:00
committed by Andrey Lushnikov
parent 81cf579275
commit 15af75f9a2
4 changed files with 83 additions and 5 deletions

View File

@@ -344,6 +344,24 @@ module.exports.addTests = function({testRunner, expect, defaultBrowserOptions})
expect(await restoredPage.evaluate(() => 7 * 8)).toBe(56);
await browser.close();
});
it('should be able to connect using browserUrl, with and without trailing slash', async({server}) => {
const originalBrowser = await puppeteer.launch(Object.assign({}, defaultBrowserOptions, {
args: ['--remote-debugging-port=21222']
}));
const browserUrl = 'http://127.0.0.1:21222';
const browser1 = await puppeteer.connect({browserUrl});
const page1 = await browser1.newPage();
expect(await page1.evaluate(() => 7 * 8)).toBe(56);
browser1.disconnect();
const browser2 = await puppeteer.connect({browserUrl: browserUrl + '/'});
const page2 = await browser2.newPage();
expect(await page2.evaluate(() => 8 * 7)).toBe(56);
browser2.disconnect();
originalBrowser.close();
});
});
describe('Puppeteer.executablePath', function() {
it('should work', async({server}) => {