github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: migrate unit tests to Mocha (#5600)

Browse Source 
Rather than maintain our own test runner we should instead lean on the community and use Mocha which is very popular and also our test runner of choice in DevTools too.

Note that this commit doesn't remove the TestRunner source as it's still used for other unit tests, but they will be updated in a future PR and then we can remove the TestRunner.

The main bulk of this PR is updating the tests as the old TestRunner passed in contextual data via the `it` function callback whereas Mocha does not, so we introduce some helpers for the tests to make it easier.
This commit is contained in:
Jack Franklin
2020-04-09 06:56:25 +01:00
committed by GitHub
parent 262da92bbb
commit 17cd8703f9
43 changed files with 4159 additions and 2812 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
test/browser.spec.js
View File

@@ -14,24 +14,29 @@
* limitations under the License.
*/
module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHROME}) {
const {describe, xdescribe, fdescribe} = testRunner;
const {it, fit, xit, it_fails_ffox} = testRunner;
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
const expect = require('expect');
const {getTestState, setupTestBrowserHooks} = require('./mocha-utils');
describe('Browser specs', function() {
setupTestBrowserHooks();
describe('Browser.version', function() {
it('should return whether we are in headless', async({browser}) => {
it('should return whether we are in headless', async() => {
const { browser, isHeadless } = getTestState();
const version = await browser.version();
expect(version.length).toBeGreaterThan(0);
expect(version.startsWith('Headless')).toBe(headless);
expect(version.startsWith('Headless')).toBe(isHeadless);
});
});
describe('Browser.userAgent', function() {
it('should include WebKit', async({browser}) => {
it('should include WebKit', async() => {
const { browser, isChrome } = getTestState();
const userAgent = await browser.userAgent();
expect(userAgent.length).toBeGreaterThan(0);
if (CHROME)
if (isChrome)
expect(userAgent).toContain('WebKit');
else
expect(userAgent).toContain('Gecko');
@@ -39,18 +44,24 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
});
describe('Browser.target', function() {
it('should return browser target', async({browser}) => {
it('should return browser target', async() => {
const { browser } = getTestState();
const target = browser.target();
expect(target.type()).toBe('browser');
});
});
describe('Browser.process', function() {
it('should return child_process instance', async function({browser}) {
it('should return child_process instance', async() => {
const { browser } = getTestState();
const process = await browser.process();
expect(process.pid).toBeGreaterThan(0);
});
it('should not return child_process for remote browser', async function({browser}) {
it('should not return child_process for remote browser', async() => {
const { browser, puppeteer } = getTestState();
const browserWSEndpoint = browser.wsEndpoint();
const remoteBrowser = await puppeteer.connect({browserWSEndpoint});
expect(remoteBrowser.process()).toBe(null);
@@ -59,7 +70,9 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
});
describe('Browser.isConnected', () => {
it('should set the browser connected state', async({browser}) => {
it('should set the browser connected state', async() => {
const { browser, puppeteer } = getTestState();
const browserWSEndpoint = browser.wsEndpoint();
const newBrowser = await puppeteer.connect({browserWSEndpoint});
expect(newBrowser.isConnected()).toBe(true);
@@ -67,4 +80,4 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
expect(newBrowser.isConnected()).toBe(false);
});
});
};
});