mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
Change let into const (#457)
This patch: - changes `let` into `const` throughout codebase - adds eslint check to prefer const over let
This commit is contained in:
Eric Bidelman
committed by
Andrey Lushnikov
Andrey Lushnikov
parent
5d6d3e0a81
commit
1f9b4fb4c8
@@ -51,8 +51,8 @@ class NetworkManager extends EventEmitter {
|
||||
*/
|
||||
async setExtraHTTPHeaders(extraHTTPHeaders) {
|
||||
this._extraHTTPHeaders = new Map(extraHTTPHeaders);
|
||||
let headers = {};
|
||||
for (let entry of extraHTTPHeaders.entries())
|
||||
const headers = {};
|
||||
for (const entry of extraHTTPHeaders.entries())
|
||||
headers[entry[0]] = entry[1];
|
||||
await this._client.send('Network.setExtraHTTPHeaders', { headers });
|
||||
}
|
||||
@@ -89,13 +89,13 @@ class NetworkManager extends EventEmitter {
|
||||
event.request.url = removeURLHash(event.request.url);
|
||||
|
||||
if (event.redirectStatusCode) {
|
||||
let request = this._interceptionIdToRequest.get(event.interceptionId);
|
||||
const request = this._interceptionIdToRequest.get(event.interceptionId);
|
||||
console.assert(request, 'INTERNAL ERROR: failed to find request for interception redirect.');
|
||||
this._handleRequestRedirect(request, event.redirectStatusCode, event.redirectHeaders);
|
||||
this._handleRequestStart(request._requestId, event.interceptionId, event.redirectUrl, event.request);
|
||||
return;
|
||||
}
|
||||
let requestHash = generateRequestHash(event.request);
|
||||
const requestHash = generateRequestHash(event.request);
|
||||
this._requestHashToInterceptions.set(requestHash, event);
|
||||
this._maybeResolveInterception(requestHash);
|
||||
}
|
||||
@@ -106,7 +106,7 @@ class NetworkManager extends EventEmitter {
|
||||
* @param {!Object} redirectHeaders
|
||||
*/
|
||||
_handleRequestRedirect(request, redirectStatus, redirectHeaders) {
|
||||
let response = new Response(this._client, request, redirectStatus, redirectHeaders);
|
||||
const response = new Response(this._client, request, redirectStatus, redirectHeaders);
|
||||
request._response = response;
|
||||
this._requestIdToRequest.delete(request._requestId);
|
||||
this._interceptionIdToRequest.delete(request._interceptionId);
|
||||
@@ -121,7 +121,7 @@ class NetworkManager extends EventEmitter {
|
||||
* @param {!Object} requestPayload
|
||||
*/
|
||||
_handleRequestStart(requestId, interceptionId, url, requestPayload) {
|
||||
let request = new Request(this._client, requestId, interceptionId, url, requestPayload);
|
||||
const request = new Request(this._client, requestId, interceptionId, url, requestPayload);
|
||||
this._requestIdToRequest.set(requestId, request);
|
||||
this._interceptionIdToRequest.set(interceptionId, request);
|
||||
this.emit(NetworkManager.Events.Request, request);
|
||||
@@ -135,13 +135,13 @@ class NetworkManager extends EventEmitter {
|
||||
// All redirects are handled in requestIntercepted.
|
||||
if (event.redirectResponse)
|
||||
return;
|
||||
let requestHash = generateRequestHash(event.request);
|
||||
const requestHash = generateRequestHash(event.request);
|
||||
this._requestHashToRequestIds.set(requestHash, event.requestId);
|
||||
this._maybeResolveInterception(requestHash);
|
||||
return;
|
||||
}
|
||||
if (event.redirectResponse) {
|
||||
let request = this._requestIdToRequest.get(event.requestId);
|
||||
const request = this._requestIdToRequest.get(event.requestId);
|
||||
this._handleRequestRedirect(request, event.redirectResponse.status, event.redirectResponse.headers);
|
||||
}
|
||||
this._handleRequestStart(event.requestId, null, event.request.url, event.request);
|
||||
@@ -165,11 +165,11 @@ class NetworkManager extends EventEmitter {
|
||||
* @param {!Object} event
|
||||
*/
|
||||
_onResponseReceived(event) {
|
||||
let request = this._requestIdToRequest.get(event.requestId);
|
||||
const request = this._requestIdToRequest.get(event.requestId);
|
||||
// FileUpload sends a response without a matching request.
|
||||
if (!request)
|
||||
return;
|
||||
let response = new Response(this._client, request, event.response.status, event.response.headers);
|
||||
const response = new Response(this._client, request, event.response.status, event.response.headers);
|
||||
request._response = response;
|
||||
this.emit(NetworkManager.Events.Response, response);
|
||||
}
|
||||
@@ -178,7 +178,7 @@ class NetworkManager extends EventEmitter {
|
||||
* @param {!Object} event
|
||||
*/
|
||||
_onLoadingFinished(event) {
|
||||
let request = this._requestIdToRequest.get(event.requestId);
|
||||
const request = this._requestIdToRequest.get(event.requestId);
|
||||
// For certain requestIds we never receive requestWillBeSent event.
|
||||
// @see https://crbug.com/750469
|
||||
if (!request)
|
||||
@@ -193,7 +193,7 @@ class NetworkManager extends EventEmitter {
|
||||
* @param {!Object} event
|
||||
*/
|
||||
_onLoadingFailed(event) {
|
||||
let request = this._requestIdToRequest.get(event.requestId);
|
||||
const request = this._requestIdToRequest.get(event.requestId);
|
||||
// For certain requestIds we never receive requestWillBeSent event.
|
||||
// @see https://crbug.com/750469
|
||||
if (!request)
|
||||
@@ -249,7 +249,7 @@ class Request {
|
||||
let headers = undefined;
|
||||
if (overrides.headers) {
|
||||
headers = {};
|
||||
for (let entry of overrides.headers)
|
||||
for (const entry of overrides.headers)
|
||||
headers[entry[0]] = entry[1];
|
||||
}
|
||||
this._client.send('Network.continueInterceptedRequest', {
|
||||
@@ -300,7 +300,7 @@ class Response {
|
||||
buffer() {
|
||||
if (!this._contentPromise) {
|
||||
this._contentPromise = this._request._completePromise.then(async() => {
|
||||
let response = await this._client.send('Network.getResponseBody', {
|
||||
const response = await this._client.send('Network.getResponseBody', {
|
||||
requestId: this._request._requestId
|
||||
});
|
||||
return Buffer.from(response.body, response.base64Encoded ? 'base64' : 'utf8');
|
||||
@@ -313,7 +313,7 @@ class Response {
|
||||
* @return {!Promise<string>}
|
||||
*/
|
||||
async text() {
|
||||
let content = await this.buffer();
|
||||
const content = await this.buffer();
|
||||
return content.toString('utf8');
|
||||
}
|
||||
|
||||
@@ -321,7 +321,7 @@ class Response {
|
||||
* @return {!Promise<!Object>}
|
||||
*/
|
||||
async json() {
|
||||
let content = await this.text();
|
||||
const content = await this.text();
|
||||
return JSON.parse(content);
|
||||
}
|
||||
|
||||
@@ -339,15 +339,15 @@ helper.tracePublicAPI(Response);
|
||||
* @return {string}
|
||||
*/
|
||||
function generateRequestHash(request) {
|
||||
let hash = {
|
||||
const hash = {
|
||||
url: request.url,
|
||||
method: request.method,
|
||||
postData: request.postData,
|
||||
headers: {},
|
||||
};
|
||||
let headers = Object.keys(request.headers);
|
||||
const headers = Object.keys(request.headers);
|
||||
headers.sort();
|
||||
for (let header of headers) {
|
||||
for (const header of headers) {
|
||||
if (header === 'Accept' || header === 'Referer' || header === 'X-DevTools-Emulate-Network-Conditions-Client-Id')
|
||||
continue;
|
||||
hash.headers[header] = request.headers[header];
|
||||
@@ -360,7 +360,7 @@ function generateRequestHash(request) {
|
||||
* @return {string}
|
||||
*/
|
||||
function removeURLHash(url) {
|
||||
let urlObject = new URL(url);
|
||||
const urlObject = new URL(url);
|
||||
urlObject.hash = '';
|
||||
return urlObject.toString();
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user