github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change let into const (#457)

Browse Source 
This patch:
- changes `let` into `const` throughout codebase
- adds eslint check to prefer const over let
This commit is contained in:
Eric Bidelman
2017-08-21 16:39:04 -07:00
committed by Andrey Lushnikov
parent 5d6d3e0a81
commit 1f9b4fb4c8
37 changed files with 495 additions and 494 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
lib/Page.js
View File

@@ -171,7 +171,7 @@ class Page extends EventEmitter {
throw new Error(`Failed to add page binding with name ${name}: window['${name}'] already exists!`);
this._pageBindings[name] = puppeteerFunction;
let expression = helper.evaluationString(addPageBinding, name);
const expression = helper.evaluationString(addPageBinding, name);
await this._client.send('Page.addScriptToEvaluateOnNewDocument', { source: expression });
await this._client.send('Runtime.evaluate', { expression, returnByValue: true });
@@ -213,15 +213,15 @@ class Page extends EventEmitter {
* @param {!Object} exceptionDetails
*/
_handleException(exceptionDetails) {
let message = helper.getExceptionMessage(exceptionDetails);
const message = helper.getExceptionMessage(exceptionDetails);
this.emit(Page.Events.PageError, new Error(message));
}
async _onConsoleAPI(event) {
if (event.type === 'debug' && event.args.length && event.args[0].value === 'driver:page-binding') {
let {name, seq, args} = JSON.parse(event.args[1].value);
let result = await this._pageBindings[name](...args);
let expression = helper.evaluationString(deliverResult, name, seq, result);
const {name, seq, args} = JSON.parse(event.args[1].value);
const result = await this._pageBindings[name](...args);
const expression = helper.evaluationString(deliverResult, name, seq, result);
this._client.send('Runtime.evaluate', { expression });
function deliverResult(name, seq, result) {
@@ -234,7 +234,7 @@ class Page extends EventEmitter {
event.args.map(arg => helper.releaseObject(this._client, arg));
return;
}
let values = await Promise.all(event.args.map(arg => helper.serializeRemoteObject(this._client, arg)));
const values = await Promise.all(event.args.map(arg => helper.serializeRemoteObject(this._client, arg)));
this.emit(Page.Events.Console, ...values);
}
@@ -249,7 +249,7 @@ class Page extends EventEmitter {
else if (event.type === 'beforeunload')
dialogType = Dialog.Type.BeforeUnload;
console.assert(dialogType, 'Unknown javascript dialog type: ' + event.type);
let dialog = new Dialog(this._client, dialogType, event.message, event.defaultPrompt);
const dialog = new Dialog(this._client, dialogType, event.message, event.defaultPrompt);
this.emit(Page.Events.Dialog, dialog);
}
@@ -419,7 +419,7 @@ class Page extends EventEmitter {
* @return {!Promise}
*/
async evaluateOnNewDocument(pageFunction, ...args) {
let source = helper.evaluationString(pageFunction, ...args);
const source = helper.evaluationString(pageFunction, ...args);
await this._client.send('Page.addScriptToEvaluateOnNewDocument', { source });
}
@@ -430,7 +430,7 @@ class Page extends EventEmitter {
async screenshot(options = {}) {
let screenshotType = null;
if (options.path) {
let mimeType = mime.lookup(options.path);
const mimeType = mime.lookup(options.path);
if (mimeType === 'image/png')
screenshotType = 'png';
else if (mimeType === 'image/jpeg')
@@ -488,14 +488,14 @@ class Page extends EventEmitter {
if (options.omitBackground)
await this._client.send('Emulation.setDefaultBackgroundColorOverride', { color: { r: 0, g: 0, b: 0, a: 0 } });
let result = await this._client.send('Page.captureScreenshot', { format, quality: options.quality, clip });
const result = await this._client.send('Page.captureScreenshot', { format, quality: options.quality, clip });
if (options.omitBackground)
await this._client.send('Emulation.setDefaultBackgroundColorOverride');
if (options.fullPage)
await this.setViewport(this._viewport);
let buffer = new Buffer(result.data, 'base64');
const buffer = new Buffer(result.data, 'base64');
if (options.path)
fs.writeFileSync(options.path, buffer);
return buffer;
@@ -506,16 +506,16 @@ class Page extends EventEmitter {
* @return {!Promise<!Buffer>}
*/
async pdf(options = {}) {
let scale = options.scale || 1;
let displayHeaderFooter = !!options.displayHeaderFooter;
let printBackground = !!options.printBackground;
let landscape = !!options.landscape;
let pageRanges = options.pageRanges || '';
const scale = options.scale || 1;
const displayHeaderFooter = !!options.displayHeaderFooter;
const printBackground = !!options.printBackground;
const landscape = !!options.landscape;
const pageRanges = options.pageRanges || '';
let paperWidth = 8.5;
let paperHeight = 11;
if (options.format) {
let format = Page.PaperFormats[options.format.toLowerCase()];
const format = Page.PaperFormats[options.format.toLowerCase()];
console.assert(format, 'Unknown paper format: ' + options.format);
paperWidth = format.width;
paperHeight = format.height;
@@ -524,13 +524,13 @@ class Page extends EventEmitter {
paperHeight = convertPrintParameterToInches(options.height) || paperHeight;
}
let marginOptions = options.margin || {};
let marginTop = convertPrintParameterToInches(marginOptions.top) || 0;
let marginLeft = convertPrintParameterToInches(marginOptions.left) || 0;
let marginBottom = convertPrintParameterToInches(marginOptions.bottom) || 0;
let marginRight = convertPrintParameterToInches(marginOptions.right) || 0;
const marginOptions = options.margin || {};
const marginTop = convertPrintParameterToInches(marginOptions.top) || 0;
const marginLeft = convertPrintParameterToInches(marginOptions.left) || 0;
const marginBottom = convertPrintParameterToInches(marginOptions.bottom) || 0;
const marginRight = convertPrintParameterToInches(marginOptions.right) || 0;
let result = await this._client.send('Page.printToPDF', {
const result = await this._client.send('Page.printToPDF', {
landscape: landscape,
displayHeaderFooter: displayHeaderFooter,
printBackground: printBackground,
@@ -543,7 +543,7 @@ class Page extends EventEmitter {
marginRight: marginRight,
pageRanges: pageRanges
});
let buffer = new Buffer(result.data, 'base64');
const buffer = new Buffer(result.data, 'base64');
if (options.path)
fs.writeFileSync(options.path, buffer);
return buffer;
@@ -583,7 +583,7 @@ class Page extends EventEmitter {
* @return {!Promise}
*/
async click(selector, options) {
let handle = await this.$(selector);
const handle = await this.$(selector);
console.assert(handle, 'No node found for selector: ' + selector);
await handle.click(options);
await handle.dispose();
@@ -594,7 +594,7 @@ class Page extends EventEmitter {
* @param {!Promise}
*/
async hover(selector) {
let handle = await this.$(selector);
const handle = await this.$(selector);
console.assert(handle, 'No node found for selector: ' + selector);
await handle.hover();
await handle.dispose();
@@ -605,7 +605,7 @@ class Page extends EventEmitter {
* @return {!Promise}
*/
async focus(selector) {
let handle = await this.$(selector);
const handle = await this.$(selector);
console.assert(handle, 'No node found for selector: ' + selector);
await handle.evaluate(element => element.focus());
await handle.dispose();
@@ -621,7 +621,7 @@ class Page extends EventEmitter {
if (options && options.delay)
delay = options.delay;
let last;
for (let char of text) {
for (const char of text) {
last = this.press(char, {text: char, delay});
if (delay)
await new Promise(f => setTimeout(f, delay));
@@ -684,7 +684,7 @@ Page.PaperFormats = {
a5: {width: 5.83, height: 8.27 },
};
let unitToPixels = {
const unitToPixels = {
'px': 1,
'in': 96,
'cm': 37.8,
@@ -703,7 +703,7 @@ function convertPrintParameterToInches(parameter) {
// Treat numbers as pixel values to be aligned with phantom's paperSize.
pixels = /** @type {number} */ (parameter);
} else if (helper.isString(parameter)) {
let text = parameter;
const text = parameter;
let unit = text.substring(text.length - 2).toLowerCase();
let valueText = '';
if (unitToPixels.hasOwnProperty(unit)) {
@@ -714,7 +714,7 @@ function convertPrintParameterToInches(parameter) {
unit = 'px';
valueText = text;
}
let value = Number(valueText);
const value = Number(valueText);
console.assert(!isNaN(value), 'Failed to parse parameter value: ' + text);
pixels = value * unitToPixels[unit];
} else {