mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
fix(Page): remove event listeners to avoid MaxListenersExceededWarning
This patch starts to properly clean up event listeners on a failed navigation (Page.goto).
This commit is contained in:
@@ -384,6 +384,7 @@ class Page extends EventEmitter {
|
||||
await this._client.send('Page.navigate', {url, referrer});
|
||||
} catch (e) {
|
||||
watcher.cancel();
|
||||
helper.removeEventListeners([listener]);
|
||||
throw e;
|
||||
}
|
||||
const error = await navigationPromise;
|
||||
|
||||
Reference in New Issue
Block a user