github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix frame.waitFor to work with complex selectors (#90)

Browse Source 
The frame.waitFor didn't account for multi-level selectors.
This patch fixes this, executing document.querySelector on every DOM mutation.
This commit is contained in:
JoelEinbinder
2017-07-18 02:10:02 -07:00
committed by Andrey Lushnikov
parent 6c1c3a0c45
commit 28265fc313
2 changed files with 28 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/test.js
View File

@@ -190,6 +190,17 @@ describe('Puppeteer', function() {
expect(added).toBe(true);
}));
it('should work when node is added through innerHTML', SX(async function() {
await page.navigate(EMPTY_PAGE);
let frame = page.mainFrame();
let added = false;
frame.waitFor('h3 div').then(() => added = true);
expect(added).toBe(false);
await frame.evaluate(addElement, 'span');
await page.$('span', span => span.innerHTML = '<h3><div></div></h3>');
expect(added).toBe(true);
}));
it('Page.waitFor is shortcut for main frame', SX(async function() {
await page.navigate(EMPTY_PAGE);
await FrameUtils.attachFrame(page, 'frame1', EMPTY_PAGE);