mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
Resolve pending callbacks when connection closes
This patch: - resolves pending callbacks in connection once it gets closed - fixes one of Page.screenshot() tests to wait for all the screenshots - starts handling ECONNRESET error in test server to avoid throwing with no good reason
This commit is contained in:
@@ -79,6 +79,12 @@ class SimpleServer {
|
||||
|
||||
_onSocket(socket) {
|
||||
this._sockets.add(socket);
|
||||
// ECONNRESET is a legit error given
|
||||
// that tab closing simply kills process.
|
||||
socket.on('error', error => {
|
||||
if (error.code !== 'ECONNRESET')
|
||||
throw error;
|
||||
});
|
||||
socket.once('close', () => this._sockets.delete(socket));
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user