github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename navigation option 'waitFor' into 'waitUntil'.

Browse Source 
This patch renames navigation option 'waitFor' into 'waitUntil' to
avoid confusion with 'page.waitFor' call.

References #39.
This commit is contained in:
Andrey Lushnikov
2017-07-14 13:59:36 -07:00
parent 76415e1be5
commit 34a96a8462
3 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/test.js
View File

@@ -274,7 +274,7 @@ describe('Puppeteer', function() {
// Navigate to a page which loads immediately and then does a bunch of
// requests via javascript's fetch method.
let navigationPromise = page.navigate(PREFIX + '/networkidle.html', {
waitFor: 'networkidle',
waitUntil: 'networkidle',
networkIdleTimeout: 100,
networkIdleInflight: 0, // Only be idle when there are 0 inflight requests
});
@@ -324,7 +324,7 @@ describe('Puppeteer', function() {
// Navigate to a page which loads immediately and then opens a bunch of
// websocket connections and then a fetch request.
let navigationPromise = page.navigate(PREFIX + '/websocket.html', {
waitFor: 'networkidle',
waitUntil: 'networkidle',
networkIdleTimeout: 100,
networkIdleInflight: 0, // Only be idle when there are 0 inflight requests/connections
});