refactor: use @puppeteer/browsers for install (#9898)

Co-authored-by: Nikolay Vitkov <34244704+Lightning00Blade@users.noreply.github.com>

test/TestExpectations.json

@@ -305,12 +305,6 @@
     "parameters": ["webDriverBiDi"],
     "expectations": ["FAIL", "TIMEOUT"]
   },
-  {
-    "testIdPattern": "[navigation.spec] navigation Page.goto should not leak listeners during navigation of 11 pages",
-    "platforms": ["darwin"],
-    "parameters": ["chrome", "webDriverBiDi"],
-    "expectations": ["PASS", "TIMEOUT"]
-  },
   {
     "testIdPattern": "[navigation.spec] navigation Page.goto should not throw an error for a 404 response with an empty body",
     "platforms": ["darwin", "linux", "win32"],
@@ -1175,6 +1169,12 @@
     "parameters": ["chrome", "webDriverBiDi"],
     "expectations": ["FAIL", "PASS", "TIMEOUT"]
   },
+  {
+    "testIdPattern": "[navigation.spec] navigation Page.goto should not leak listeners during navigation of 11 pages",
+    "platforms": ["darwin"],
+    "parameters": ["chrome", "webDriverBiDi"],
+    "expectations": ["PASS", "TIMEOUT"]
+  },
   {
     "testIdPattern": "[navigation.spec] navigation Page.goto should send referer",
     "platforms": ["darwin", "linux", "win32"],

test/installation/package.json

@@ -26,10 +26,11 @@
       ]
     },
     "build:packages": {
-      "command": "npm pack --workspace puppeteer --workspace puppeteer-core",
+      "command": "npm pack --workspace puppeteer --workspace puppeteer-core --workspace @puppeteer/browsers",
       "dependencies": [
         "../../packages/puppeteer:build",
-        "../../packages/puppeteer-core:build"
+        "../../packages/puppeteer-core:build",
+        "../../packages/browsers:build"
       ],
       "files": [],
       "output": [

test/installation/src/constants.ts

@@ -22,6 +22,9 @@ import glob from 'glob';
 export const PUPPETEER_CORE_PACKAGE_PATH = resolve(
   glob.sync('puppeteer-core-*.tgz')[0]!
 );
+export const PUPPETEER_BROWSERS_PACKAGE_PATH = resolve(
+  glob.sync('puppeteer-browsers-[0-9]*.tgz')[0]!
+);
 export const PUPPETEER_PACKAGE_PATH = resolve(
   glob.sync('puppeteer-[0-9]*.tgz')[0]!
 );

test/installation/src/describeInstallation.ts

@@ -22,6 +22,7 @@ import {join} from 'path';
 import {
   PUPPETEER_CORE_PACKAGE_PATH,
   PUPPETEER_PACKAGE_PATH,
+  PUPPETEER_BROWSERS_PACKAGE_PATH,
 } from './constants.js';
 import {execFile} from './util.js';
 
@@ -78,6 +79,8 @@ export const describeInstallation = (
             return PUPPETEER_PACKAGE_PATH;
           case 'puppeteer-core':
             return PUPPETEER_CORE_PACKAGE_PATH;
+          case '@puppeteer/browsers':
+            return PUPPETEER_BROWSERS_PACKAGE_PATH;
           default:
             return module;
         }
@@ -102,7 +105,7 @@ export const describeInstallation = (
 
     after(async () => {
       if (process.env['KEEP_SANDBOX']) {
-        await rm(sandbox, {recursive: true, force: true});
+        await rm(sandbox, {recursive: true, force: true, maxRetries: 5});
       }
     });
 

test/installation/src/puppeteer-configuration.spec.ts

@@ -24,7 +24,7 @@ import {readAsset} from './util.js';
 describeInstallation(
   '`puppeteer` with configuration',
   {
-    dependencies: ['puppeteer-core', 'puppeteer'],
+    dependencies: ['puppeteer-core', '@puppeteer/browsers', 'puppeteer'],
     before: async cwd => {
       await writeFile(
         join(cwd, '.puppeteerrc.cjs'),

test/installation/src/puppeteer-firefox.spec.ts

@@ -24,7 +24,7 @@ import {readAsset} from './util.js';
 describeInstallation(
   '`puppeteer` with Firefox',
   {
-    dependencies: ['puppeteer-core', 'puppeteer'],
+    dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
     env: cwd => {
       return {
         PUPPETEER_CACHE_DIR: join(cwd, '.cache', 'puppeteer'),

test/installation/src/puppeteer-webpack.spec.ts

@@ -23,7 +23,7 @@ import {execFile, readAsset} from './util.js';
 describeInstallation(
   '`puppeteer` with Webpack',
   {
-    dependencies: ['puppeteer-core', 'puppeteer'],
+    dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
     devDependencies: ['webpack', 'webpack-cli'],
     env: cwd => {
       return {

test/installation/src/puppeteer.spec.ts

@@ -24,7 +24,7 @@ import {readAsset} from './util.js';
 describeInstallation(
   '`puppeteer`',
   {
-    dependencies: ['puppeteer-core', 'puppeteer'],
+    dependencies: ['@puppeteer/browsers', 'puppeteer-core', 'puppeteer'],
     env: cwd => {
       return {
         PUPPETEER_CACHE_DIR: join(cwd, '.cache', 'puppeteer'),