github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(firefox): support Browser.target() (#4028)

Browse Source 
Support browser target.

Drive-by: switch over to a more devtools'ish protocol:

- use `targetId` instead of `pageId` everywhere
- use target events instead of tab events
This commit is contained in:
Andrey Lushnikov
2019-02-17 10:23:48 -08:00
committed by GitHub
parent ea482c4751
commit 4a4793a5e1
5 changed files with 47 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/browser.spec.js
View File

@@ -20,7 +20,7 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer}) {
const {beforeAll, beforeEach, afterAll, afterEach} = testRunner;
describe('Browser.target', function() {
it_fails_ffox('should return browser target', async({browser}) => {
it('should return browser target', async({browser}) => {
const target = browser.target();
expect(target.type()).toBe('browser');
});