github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: setRequestInterception and setExtraHTTPHeaders not working together (#1734)

Browse Source 
This patch starts lowering header keys while generating request hashes.

Fixes #1729.
This commit is contained in:
yujiosaka
2018-01-10 09:52:28 +09:00
committed by Andrey Lushnikov
parent dcc1b24395
commit 5843f6f775
2 changed files with 15 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/NetworkManager.js
View File

@@ -571,10 +571,12 @@ function generateRequestHash(request) {
if (!normalizedURL.startsWith('data:')) {
const headers = Object.keys(request.headers);
headers.sort();
for (const header of headers) {
if (header === 'Accept' || header === 'Referer' || header === 'X-DevTools-Emulate-Network-Conditions-Client-Id')
for (let header of headers) {
const headerValue = request.headers[header];
header = header.toLowerCase();
if (header === 'accept' || header === 'referer' || header === 'x-devtools-emulate-network-conditions-client-id')
continue;
hash.headers[header] = request.headers[header];
hash.headers[header] = headerValue;
}
}
return JSON.stringify(hash);