github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove browser.closePage. (#124)

Browse Source 
Remove browser.closePage. Closes #116
This commit is contained in:
JoelEinbinder
2017-07-25 00:44:13 -07:00
committed by Andrey Lushnikov
parent d4c5aee5a8
commit 615381c70e
2 changed files with 4 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Browser.js
View File

@@ -84,8 +84,8 @@ class Browser {
}
/**
* @return {!Promise<!Page>}
*/
* @return {!Promise<!Page>}
*/
async newPage() {
await this._ensureChromeIsRunning();
if (!this._chromeProcess || this._terminated)
@@ -96,17 +96,8 @@ class Browser {
}
/**
* @param {!Page} page
*/
async closePage(page) {
if (!this._chromeProcess || this._terminated)
throw new Error('ERROR: this chrome instance is not running');
await page.close();
}
/**
* @return {string}
*/
* @return {string}
*/
async version() {
await this._ensureChromeIsRunning();
let version = await Connection.version(this._remoteDebuggingPort);