github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(firefox): report more console messages (including warnings) (#4005)

Browse Source
This commit is contained in:
Andrey Lushnikov
2019-02-13 23:22:45 -08:00
committed by GitHub
parent 0b40d04b99
commit 6350cf0892
3 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/page.spec.js
View File

@@ -333,14 +333,17 @@ module.exports.addTests = function({testRunner, expect, headless, Errors, Device
]);
expect(message.text()).toBe('JSHandle@object');
});
it_fails_ffox('should trigger correct Log', async({page, server}) => {
it('should trigger correct Log', async({page, server}) => {
await page.goto('about:blank');
const [message] = await Promise.all([
waitEvent(page, 'console'),
page.evaluate(async url => fetch(url).catch(e => {}), server.EMPTY_PAGE)
]);
expect(message.text()).toContain('No \'Access-Control-Allow-Origin\'');
expect(message.type()).toEqual('error');
expect(message.text()).toContain('Access-Control-Allow-Origin');
if (CHROME)
expect(message.type()).toEqual('error');
else
expect(message.type()).toEqual('warn');
});
it_fails_ffox('should have location when fetch fails', async({page, server}) => {
await page.goto(server.EMPTY_PAGE);