github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(types): add types for $eval (#6135)

Browse Source 
This pulls in the types (based on the DefinitelyTyped repo) for
`page.$eval` (and the `$eval` method on other classes). The `$eval`
method is quite hard to type due to the way we wrap and unwrap
ElementHandles that are passed to / returned from the `pageFunction`
that users provide.

Longer term we can improve the types by providing type overloads as
DefinitelyTyped does but I've deferred that for now (see the `TODO` in
the code for more details).
This commit is contained in:
Jack Franklin
2020-07-02 10:09:34 +01:00
committed by GitHub
parent 8370ec88ae
commit 6474edb9ba
22 changed files with 282 additions and 72 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/queryselector.spec.ts
View File

@@ -49,7 +49,7 @@ describe('querySelector', function () {
const divHandle = await page.$('div');
const text = await page.$eval(
'section',
(e, div) => e.textContent + div.textContent,
(e, div: HTMLElement) => e.textContent + div.textContent,
divHandle
);
expect(text).toBe('hello world');
@@ -174,7 +174,10 @@ describe('querySelector', function () {
'<html><body><div class="tweet"><div class="like">100</div><div class="retweets">10</div></div></body></html>'
);
const tweet = await page.$('.tweet');
const content = await tweet.$eval('.like', (node) => node.innerText);
const content = await tweet.$eval(
'.like',
(node: HTMLElement) => node.innerText
);
expect(content).toBe('100');
});
@@ -185,7 +188,10 @@ describe('querySelector', function () {
'<div class="a">not-a-child-div</div><div id="myId"><div class="a">a-child-div</div></div>';
await page.setContent(htmlContent);
const elementHandle = await page.$('#myId');
const content = await elementHandle.$eval('.a', (node) => node.innerText);
const content = await elementHandle.$eval(
'.a',
(node: HTMLElement) => node.innerText
);
expect(content).toBe('a-child-div');
});
@@ -197,7 +203,7 @@ describe('querySelector', function () {
await page.setContent(htmlContent);
const elementHandle = await page.$('#myId');
const errorMessage = await elementHandle
.$eval('.a', (node) => node.innerText)
.$eval('.a', (node: HTMLElement) => node.innerText)
.catch((error) => error.message);
expect(errorMessage).toBe(
`Error: failed to find element matching selector ".a"`