github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Return remote object description for unserializable objects

Browse Source 
This patch starts handling unserializable objects by returning their
description.

Fixes #86.
This commit is contained in:
Andrey Lushnikov
2017-07-18 00:03:52 -07:00
parent 72b7e50f9e
commit 6c1c3a0c45
2 changed files with 26 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/test.js
View File

@@ -128,6 +128,10 @@ describe('Puppeteer', function() {
let result = await page.evaluate(() => -Infinity);
expect(Object.is(result, -Infinity)).toBe(true);
}));
it('should not fail for window object', SX(async function() {
let result = await page.evaluate(() => window);
expect(result).toBe('Window');
}));
});
describe('Page.injectFile', function() {
@@ -256,6 +260,13 @@ describe('Puppeteer', function() {
'calling console.error',
]);
}));
it('should not fail for window object', SX(async function() {
let windowObj = null;
page.once('console', arg => windowObj = arg);
page.evaluate(() => console.error(window));
await waitForEvents(page, 'console');
expect(windowObj).toBe('Window');
}));
});
describe('Page.navigate', function() {