github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: fix sort-test-expectations (#12107)

Browse Source
This commit is contained in:
Nikolay Vitkov
2024-03-19 15:09:13 +01:00
committed by GitHub
parent c7936f0888
commit 73f3f4e173
2 changed files with 6 additions and 95 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tools/sort-test-expectations.mjs
View File

@@ -78,14 +78,14 @@ const toBeRemoved = new Set();
for (let i = testExpectations.length - 1; i >= 0; i--) {
const expectation = testExpectations[i];
const params = new Set(expectation.parameters);
const labels = new Set(expectation.expectations);
const expectations = new Set(expectation.expectations);
const platforms = new Set(expectation.platforms);
let foundMatch = false;
for (let j = i - 1; j >= 0; j--) {
const candidate = testExpectations[j];
const candidateParams = new Set(candidate.parameters);
const candidateLabels = new Set(candidate.expectations);
const candidateExpectations = new Set(candidate.expectations);
const candidatePlatforms = new Set(candidate.platforms);
if (
@@ -93,11 +93,11 @@ for (let i = testExpectations.length - 1; i >= 0; i--) {
expectation.testIdPattern,
candidate.testIdPattern
) &&
isSubset(candidateParams, params) &&
isSubset(candidatePlatforms, platforms)
isSubset(candidatePlatforms, platforms) &&
(isSubset(params, candidateParams) || isSubset(candidateParams, params))
) {
foundMatch = true;
if (isSubset(candidateLabels, labels)) {
if (isSubset(candidateExpectations, expectations)) {
console.log('removing', expectation, 'already covered by', candidate);
toBeRemoved.add(expectation);
}
@@ -105,7 +105,7 @@ for (let i = testExpectations.length - 1; i >= 0; i--) {
}
}
if (!foundMatch && isSubset(new Set(['PASS']), labels)) {
if (!foundMatch && isSubset(new Set(['PASS']), expectations)) {
console.log(
'removing',
expectation,