github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(firefox): implement frame.goto / frame.waitForNavigation (#3992)

Browse Source 
Some corner cases regarding iframes being detached during navigation
are not yet supported.
This commit is contained in:
Andrey Lushnikov
2019-02-12 20:10:53 -08:00
committed by GitHub
parent f0fba56ea3
commit 89d0f1e1e7
6 changed files with 235 additions and 209 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/navigation.spec.js
View File

@@ -472,7 +472,7 @@ module.exports.addTests = function({testRunner, expect, Errors, CHROME}) {
});
describe('Frame.goto', function() {
it_fails_ffox('should navigate subframes', async({page, server}) => {
it('should navigate subframes', async({page, server}) => {
await page.goto(server.PREFIX + '/frames/one-frame.html');
expect(page.frames()[0].url()).toContain('/frames/one-frame.html');
expect(page.frames()[1].url()).toContain('/frames/frame.html');
@@ -522,7 +522,7 @@ module.exports.addTests = function({testRunner, expect, Errors, CHROME}) {
});
describe('Frame.waitForNavigation', function() {
it_fails_ffox('should work', async({page, server}) => {
it('should work', async({page, server}) => {
await page.goto(server.PREFIX + '/frames/one-frame.html');
const frame = page.frames()[1];
const [response] = await Promise.all([