github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename Page.Events.ConsoleMessageAdded -> Page.Events.ConsoleMessage

Browse Source 
This patch:
- renames ConsoleMessageAdded into ConsoleMessage for the sake of
  clarity
- adds a test to cover basic functionality
This commit is contained in:
Andrey Lushnikov
2017-05-13 11:05:54 -07:00
parent 2b0d0e6551
commit 8a8076c15b
4 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Page.js
View File

@@ -204,7 +204,7 @@ class Page extends EventEmitter {
_onConsoleAPI(event) {
var values = event.args.map(arg => arg.value || arg.description || '');
this.emit(Page.Events.ConsoleMessageAdded, values.join(' '));
this.emit(Page.Events.ConsoleMessage, values.join(' '));
}
/**
@@ -416,7 +416,7 @@ Page.ScreenshotTypes = {
};
Page.Events = {
ConsoleMessageAdded: 'Page.Events.ConsoleMessageAdded',
ConsoleMessage: 'Page.Events.ConsoleMessage',
DialogOpened: 'Page.Events.DialogOpened',
ExceptionThrown: 'Page.Events.ExceptionThrown',
ResourceLoadingFailed: 'Page.Events.ResourceLoadingFailed',