github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(types): improve page.evaluate types (#6193)

Browse Source
This commit is contained in:
Jack Franklin
2020-07-10 11:52:13 +01:00
committed by GitHub
parent 31309b0e20
commit 9b3005c105
32 changed files with 216 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
test/keyboard.spec.ts
View File

@@ -387,7 +387,15 @@ describe('Keyboard', function () {
});
});
await page.keyboard.press('Meta');
const [key, code, metaKey] = await page.evaluate('result');
// Have to do this because we lose a lot of type info when evaluating a
// string not a function. This is why functions are recommended rather than
// using strings (although we'll leave this test so we have coverage of both
// approaches.)
const [key, code, metaKey] = (await page.evaluate('result')) as [
string,
string,
boolean
];
if (isFirefox && os.platform() !== 'darwin') expect(key).toBe('OS');
else expect(key).toBe('Meta');