feat(types): improve page.evaluate types (#6193)

This commit is contained in:
Jack Franklin
2020-07-10 11:52:13 +01:00
committed by GitHub
parent 31309b0e20
commit 9b3005c105
32 changed files with 216 additions and 106 deletions

View File

@@ -103,7 +103,7 @@ describe('querySelector', function () {
const elements = await page.$$('div');
expect(elements.length).toBe(2);
const promises = elements.map((element) =>
page.evaluate((e) => e.textContent, element)
page.evaluate((e: HTMLElement) => e.textContent, element)
);
expect(await Promise.all(promises)).toEqual(['A', 'B']);
});
@@ -151,7 +151,10 @@ describe('querySelector', function () {
const html = await page.$('html');
const second = await html.$('.second');
const inner = await second.$('.inner');
const content = await page.evaluate((e) => e.textContent, inner);
const content = await page.evaluate(
(e: HTMLElement) => e.textContent,
inner
);
expect(content).toBe('A');
});
@@ -263,7 +266,7 @@ describe('querySelector', function () {
const elements = await html.$$('div');
expect(elements.length).toBe(2);
const promises = elements.map((element) =>
page.evaluate((e) => e.textContent, element)
page.evaluate((e: HTMLElement) => e.textContent, element)
);
expect(await Promise.all(promises)).toEqual(['A', 'B']);
});
@@ -291,7 +294,10 @@ describe('querySelector', function () {
const html = await page.$('html');
const second = await html.$x(`./body/div[contains(@class, 'second')]`);
const inner = await second[0].$x(`./div[contains(@class, 'inner')]`);
const content = await page.evaluate((e) => e.textContent, inner[0]);
const content = await page.evaluate(
(e: HTMLElement) => e.textContent,
inner[0]
);
expect(content).toBe('A');
});