mirror of
https://github.com/puppeteer/puppeteer
synced 2024-06-14 14:02:48 +00:00
feat(Page): add option to run 'beforeunload' when closing the page (#2478)
Today, `page.close()` method doesn't run page's beforeunload listeners. This way users can be sure that `page.close()` actually closes the page. This patch adds an optional `runBeforeUnload` option to the `page.close()` method that would run beforeunload listeners. Note: running beforeunload handlers might cancel page closing. Fixes #2386.
This commit is contained in:
5
test/assets/beforeunload.html
Normal file
5
test/assets/beforeunload.html
Normal file
@@ -0,0 +1,5 @@
|
||||
<script>
|
||||
window.addEventListener('beforeunload', event => {
|
||||
event.returnValue = 'Leave?';
|
||||
});
|
||||
</script>
|
||||
Reference in New Issue
Block a user