github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): browser.disconnect should not be awaited (#4446)

Browse Source 
browser.disconnect does not return a promise
This commit is contained in:
Darío Kondratiuk
2019-05-21 11:26:04 -03:00
committed by Andrey Lushnikov
parent 90a1032300
commit bad98baf70
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
test/browser.spec.js
View File

@@ -57,7 +57,7 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
const browserWSEndpoint = browser.wsEndpoint();
const remoteBrowser = await puppeteer.connect({browserWSEndpoint});
expect(remoteBrowser.process()).toBe(null);
await remoteBrowser.disconnect();
remoteBrowser.disconnect();
});
});
@@ -66,7 +66,7 @@ module.exports.addTests = function({testRunner, expect, headless, puppeteer, CHR
const browserWSEndpoint = browser.wsEndpoint();
const newBrowser = await puppeteer.connect({browserWSEndpoint});
expect(newBrowser.isConnected()).toBe(true);
await newBrowser.disconnect();
newBrowser.disconnect();
expect(newBrowser.isConnected()).toBe(false);
});
});