github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not leak event listeners on navigation

Browse Source 
This patch:
- introduces helper.addEventListener/helper.removeEventListeners
  to simplify event management
- moves NavigatorWatchdog over to the helper.addEventListener to
  stop leaking event listeners
This commit is contained in:
Andrey Lushnikov
2017-07-22 17:03:58 -07:00
parent 5757bc18f2
commit c4904b4e10
3 changed files with 56 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
test/test.js
View File

@@ -364,7 +364,7 @@ describe('Puppeteer', function() {
} catch (e) {
error = e;
}
expect(error.message).toContain('SSL Certiciate error');
expect(error.message).toContain('SSL Certificate error');
}));
it('should fail when exceeding maximum navigation timeout', SX(async function() {
let error = null;
@@ -492,6 +492,15 @@ describe('Puppeteer', function() {
// Expect navigation to succeed.
expect(response.ok).toBe(true);
}));
it('should not leak listeners durint navigation', SX(async function() {
let warning = null;
const warningHandler = w => warning = w;
process.on('warning', warningHandler);
for (let i = 0; i < 20; ++i)
await page.navigate(EMPTY_PAGE);
process.removeListener('warning', warningHandler);
expect(warning).toBe(null);
}));
});
describe('Page.waitForNavigation', function() {