github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: page.goto options type should be optional (#6038)

Browse Source 
The TypeScript definition erroneously made `options` required. We can
fix it by providing a default value, which means users calling the
function will be able to leave it blank without TS complaining.

Issues like this are a +1 to porting our tests to TypeScript in order to
catch these on our own test suite, so that's something we should look into.
This commit is contained in:
Jack Franklin
2020-06-18 12:44:46 +01:00
committed by GitHub
parent 44402b75a0
commit ce34c0a4ff
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
new-docs/puppeteer.frame.goto.md
View File

@@ -7,7 +7,7 @@
<b>Signature:</b>
```typescript
goto(url: string, options: {
goto(url: string, options?: {
referer?: string;
timeout?: number;
waitUntil?: PuppeteerLifeCycleEvent | PuppeteerLifeCycleEvent[];