github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: better timeout stack trace (#2843)

Browse Source 
fixes #2653
This commit is contained in:
Yaniv Efraim
2018-07-05 02:39:09 +03:00
committed by Andrey Lushnikov
parent 22fa00a7b3
commit cfc0571c1a
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/FrameManager.js
View File

@@ -836,8 +836,10 @@ class WaitTask {
});
// Since page navigation requires us to re-install the pageScript, we should track
// timeout on our end.
if (timeout)
this._timeoutTimer = setTimeout(() => this.terminate(new Error(`waiting for ${title} failed: timeout ${timeout}ms exceeded`)), timeout);
if (timeout) {
const timeoutError = new Error(`waiting for ${title} failed: timeout ${timeout}ms exceeded`);
this._timeoutTimer = setTimeout(() => this.terminate(timeoutError), timeout);
}
this.rerun();
}