Determine failed navigation based on Frame.unreachedURL (#365)

This patch starts using frame.unreachedURL property from
frameNavigated event to determine if the page navigation
was successful.
This commit is contained in:
Andrey Lushnikov
2017-08-17 23:24:16 -07:00
committed by GitHub
parent ae14c1eee4
commit d71feb63d0
2 changed files with 11 additions and 5 deletions

View File

@@ -130,6 +130,14 @@ class FrameManager extends EventEmitter {
this._frames.delete(frame._id);
this.emit(FrameManager.Events.FrameDetached, frame);
}
/**
* @param {!Frame} frame
* @return {boolean}
*/
isMainFrameLoadingFailed() {
return !!this._mainFrame._loadingFailed;
}
}
/** @enum {string} */
@@ -337,6 +345,7 @@ class Frame {
_navigated(framePayload) {
this._name = framePayload.name;
this._url = framePayload.url;
this._loadingFailed = !!framePayload.unreachableUrl;
}
_detach() {