github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(page): respect timeout 0 in page.waitForFunction (#2563)

Browse Source 
The in-page task should not set timeout when timeout is 0.

Fixes #2540.
This commit is contained in:
Andrey Lushnikov
2018-05-25 16:45:04 -07:00
committed by GitHub
parent 6a0627a411
commit debfe7e0b1
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/FrameManager.js
View File

@@ -911,7 +911,8 @@ class WaitTask {
async function waitForPredicatePageFunction(predicateBody, polling, timeout, ...args) {
const predicate = new Function('...args', predicateBody);
let timedOut = false;
setTimeout(() => timedOut = true, timeout);
if (timeout)
setTimeout(() => timedOut = true, timeout);
if (polling === 'raf')
return await pollRaf();
if (polling === 'mutation')