github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(Page): report 'Log' domain entries as 'console' events (#2400)

Browse Source 
Fixes #1939
This commit is contained in:
Yaniv Efraim
2018-04-28 07:40:09 +03:00
committed by Andrey Lushnikov
parent 58c46680f3
commit e236887bbb
2 changed files with 20 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
test/page.spec.js
View File

@@ -331,6 +331,15 @@ module.exports.addTests = function({testRunner, expect, puppeteer, DeviceDescrip
]);
expect(message.text()).toBe('JSHandle@object');
});
it('should trigger correct Log', async({page, server}) => {
await page.goto('about:blank');
let message;
page.on('console', event => message = event);
page.evaluate(async url => fetch(url).catch(e => {}), server.EMPTY_PAGE);
await waitEvent(page, 'console');
expect(message.text()).toContain('No \'Access-Control-Allow-Origin\'');
expect(message.type()).toEqual('error');
});
});
describe('Page.Events.DOMContentLoaded', function() {