github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce consistent spacing around object curlys (#5700)

Browse Source 
The codebase was incredibly inconsistent with the use of spacing around
curly braces, e.g.:

```
// this?
const a = {b: 1}
// or?
const a = { b: 1 }
```

This extended into import statements also. Google's styleguide is no
spacing, so we're going with that.
This commit is contained in:
Jack Franklin
2020-04-21 10:40:04 +01:00
committed by GitHub
parent 3600f2f99b
commit e3922ea1f3
55 changed files with 791 additions and 789 deletions
Download Patch File Download Diff File Expand all files Collapse all files

48
test/coverage.spec.js
View File

@@ -23,19 +23,19 @@ describe('Coverage specs', function() {
setupTestPageAndContextHooks();
it('should work', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/simple.html', {waitUntil: 'networkidle0'});
const coverage = await page.coverage.stopJSCoverage();
expect(coverage.length).toBe(1);
expect(coverage[0].url).toContain('/jscoverage/simple.html');
expect(coverage[0].ranges).toEqual([
{ start: 0, end: 17 },
{ start: 35, end: 61 },
{start: 0, end: 17},
{start: 35, end: 61},
]);
});
it('should report sourceURLs', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/sourceurl.html');
@@ -44,7 +44,7 @@ describe('Coverage specs', function() {
expect(coverage[0].url).toBe('nicename.js');
});
it('should ignore eval() scripts by default', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/eval.html');
@@ -52,7 +52,7 @@ describe('Coverage specs', function() {
expect(coverage.length).toBe(1);
});
it('shouldn\'t ignore eval() scripts if reportAnonymousScripts is true', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage({reportAnonymousScripts: true});
await page.goto(server.PREFIX + '/jscoverage/eval.html');
@@ -61,7 +61,7 @@ describe('Coverage specs', function() {
expect(coverage.length).toBe(2);
});
it('should ignore pptr internal scripts if reportAnonymousScripts is true', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage({reportAnonymousScripts: true});
await page.goto(server.EMPTY_PAGE);
@@ -71,7 +71,7 @@ describe('Coverage specs', function() {
expect(coverage.length).toBe(0);
});
it('should report multiple scripts', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/multiple.html');
@@ -82,7 +82,7 @@ describe('Coverage specs', function() {
expect(coverage[1].url).toContain('/jscoverage/script2.js');
});
it('should report right ranges', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/ranges.html');
@@ -94,7 +94,7 @@ describe('Coverage specs', function() {
expect(entry.text.substring(range.start, range.end)).toBe(`console.log('used!');`);
});
it('should report scripts that have no coverage', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/unused.html');
@@ -105,7 +105,7 @@ describe('Coverage specs', function() {
expect(entry.ranges.length).toBe(0);
});
it('should work with conditionals', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.PREFIX + '/jscoverage/involved.html');
@@ -114,7 +114,7 @@ describe('Coverage specs', function() {
});
describe('resetOnNavigation', function() {
it('should report scripts across navigations when disabled', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage({resetOnNavigation: false});
await page.goto(server.PREFIX + '/jscoverage/multiple.html');
@@ -124,7 +124,7 @@ describe('Coverage specs', function() {
});
it('should NOT report scripts across navigations when enabled', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage(); // Enabled by default.
await page.goto(server.PREFIX + '/jscoverage/multiple.html');
@@ -135,7 +135,7 @@ describe('Coverage specs', function() {
});
// @see https://crbug.com/990945
xit('should not hang when there is a debugger statement', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startJSCoverage();
await page.goto(server.EMPTY_PAGE);
@@ -151,7 +151,7 @@ describe('Coverage specs', function() {
setupTestPageAndContextHooks();
it('should work', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.goto(server.PREFIX + '/csscoverage/simple.html');
@@ -165,7 +165,7 @@ describe('Coverage specs', function() {
expect(coverage[0].text.substring(range.start, range.end)).toBe('div { color: green; }');
});
it('should report sourceURLs', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.goto(server.PREFIX + '/csscoverage/sourceurl.html');
@@ -174,7 +174,7 @@ describe('Coverage specs', function() {
expect(coverage[0].url).toBe('nicename.css');
});
it('should report multiple stylesheets', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.goto(server.PREFIX + '/csscoverage/multiple.html');
@@ -185,7 +185,7 @@ describe('Coverage specs', function() {
expect(coverage[1].url).toContain('/csscoverage/stylesheet2.css');
});
it('should report stylesheets that have no coverage', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.goto(server.PREFIX + '/csscoverage/unused.html');
@@ -195,7 +195,7 @@ describe('Coverage specs', function() {
expect(coverage[0].ranges.length).toBe(0);
});
it('should work with media queries', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.goto(server.PREFIX + '/csscoverage/media.html');
@@ -207,7 +207,7 @@ describe('Coverage specs', function() {
]);
});
it('should work with complicated usecases', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.goto(server.PREFIX + '/csscoverage/involved.html');
@@ -215,7 +215,7 @@ describe('Coverage specs', function() {
expect(JSON.stringify(coverage, null, 2).replace(/:\d{4}\//g, ':<PORT>/')).toBeGolden('csscoverage-involved.txt');
});
it('should ignore injected stylesheets', async() => {
const { page } = getTestState();
const {page} = getTestState();
await page.coverage.startCSSCoverage();
await page.addStyleTag({content: 'body { margin: 10px;}'});
@@ -227,7 +227,7 @@ describe('Coverage specs', function() {
});
describe('resetOnNavigation', function() {
it('should report stylesheets across navigations', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage({resetOnNavigation: false});
await page.goto(server.PREFIX + '/csscoverage/multiple.html');
@@ -236,7 +236,7 @@ describe('Coverage specs', function() {
expect(coverage.length).toBe(2);
});
it('should NOT report scripts across navigations', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage(); // Enabled by default.
await page.goto(server.PREFIX + '/csscoverage/multiple.html');
@@ -246,7 +246,7 @@ describe('Coverage specs', function() {
});
});
it('should work with a recently loaded stylesheet', async() => {
const { page, server } = getTestState();
const {page, server} = getTestState();
await page.coverage.startCSSCoverage();
await page.evaluate(async url => {