github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't throw on bad access (#8472)

Browse Source
This commit is contained in:
jrandolf
2022-06-07 16:17:21 +02:00
committed by GitHub
parent e14256010d
commit e8378666c6
2 changed files with 33 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
test/input.spec.ts
View File

@@ -235,7 +235,7 @@ describe('input tests', function () {
.catch((error_) => (error = error_));
expect(error).not.toBe(null);
});
it('should fail for non-existent files', async () => {
it('should succeed even for non-existent files', async () => {
const { page } = getTestState();
await page.setContent(`<input type=file>`);
@@ -243,11 +243,29 @@ describe('input tests', function () {
page.waitForFileChooser(),
page.click('input'),
]);
let error = null;
let error: Error | undefined;
await chooser
.accept(['file-does-not-exist.txt'])
.catch((error_) => (error = error_));
expect(error).not.toBe(null);
expect(error).toBeUndefined();
});
it('should error on read of non-existent files', async () => {
const { page } = getTestState();
await page.setContent(`<input type=file>`);
page
.waitForFileChooser()
.then((chooser) => chooser.accept(['file-does-not-exist.txt']));
expect(
await page.$eval('input', async (picker: HTMLInputElement) => {
picker.click();
await new Promise((x) => (picker.oninput = x));
const reader = new FileReader();
const promise = new Promise((fulfill) => (reader.onerror = fulfill));
reader.readAsText(picker.files[0]);
return promise.then(() => false);
})
).toBeFalsy();
});
it('should fail when accepting file chooser twice', async () => {
const { page } = getTestState();