github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(tracing): start without options (#4388)

Browse Source
This commit is contained in:
Andrey Lushnikov
2019-05-09 17:15:33 -07:00
committed by GitHub
parent 9a2fb2a0d4
commit ef24c69c62
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/Tracing.js
View File

@@ -31,9 +31,9 @@ class Tracing {
}
/**
* @param {!{path: string, screenshots?: boolean, categories?: !Array<string>}} options
* @param {!{path?: string, screenshots?: boolean, categories?: !Array<string>}} options
*/
async start(options) {
async start(options = {}) {
assert(!this._recording, 'Cannot start recording trace while already recording trace.');
const defaultCategories = [
@@ -75,7 +75,7 @@ class Tracing {
/**
* @param {string} handle
* @param {string} path
* @param {?string} path
*/
async _readStream(handle, path) {
let eof = false;