github/puppeteer
0
0
Fork 0
mirror of https://github.com/puppeteer/puppeteer synced 2024-06-14 14:02:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(Page.waitForSelector): "visible" option should check parent visibility (#1354)

Browse Source 
This patch starts checking for boundingClientRect to make sure that the
element is visible.
This commit is contained in:
JoelEinbinder
2017-11-10 15:44:01 -08:00
committed by Andrey Lushnikov
parent 44d1e834a4
commit f8d19e79e7
2 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/FrameManager.js
View File

@@ -502,8 +502,16 @@ class Frame {
if (!waitForVisible && !waitForHidden)
return true;
const style = window.getComputedStyle(node);
const isVisible = style && style.display !== 'none' && style.visibility !== 'hidden';
const isVisible = style && style.visibility !== 'hidden' && hasVisibleBoundingBox();
return (waitForVisible === isVisible || waitForHidden === !isVisible);
/**
* @return {boolean}
*/
function hasVisibleBoundingBox() {
const rect = node.getBoundingClientRect();
return !!(rect.top || rect.bottom || rect.width || rect.height);
}
}
}