4 Commits

Author	SHA1	Message	Date
Jack Franklin	bdaba7829d	fix: jsonValue() type is generic (#6865) ... During the migration to TS we changed `jsonValue` so it returned `<Record<string, unknown>>`. This is only true if all the JSON values it returns are objects; but it could return an array, a string, a number, etc. Therefore we make the type generic, setting the default to `unknown`, so the user has control over the type.	2021-02-11 09:50:15 +00:00
Jack Franklin	ffec2475d0	chore: enforce file extensions on imports (#6202) ... * chore: enforce file extensions on imports To make our output agnostic it should include file extensions in the output, as per the ESM spec. It's a bit odd for Node packages but makes it easier to publish a browser build.	2020-07-13 10:22:26 +01:00
Jack Franklin	9b3005c105	feat(types): improve page.evaluate types (#6193)	2020-07-10 11:52:13 +01:00
Jack Franklin	28797dee41	chore: migrate tests to TypeScript (#6075) ... This CL migrates all the tests to TypeScript. The main benefits of this is that we start consuming our TypeScript definitions and therefore find errors in them. The act of migrating found some bugs in our definitions and now we can be sure to avoid them going forwards. You'll notice the addition of some `TODO`s in the code; I didn't want this CL to get any bigger than it already is but I intend to follow those up once this lands. It's mostly figuring out how to extend the `expect` types with our `toBeGolden` helpers and some other slight confusions with types that the tests exposed. Co-authored-by: Mathias Bynens <mathias@qiwi.be>	2020-06-23 07:18:46 +02:00