thunderstrike/plane
2
0
Fork 0
forked from github/plane
Code Pull Requests Activity

fix: error validation for empty length

Browse Source
This commit is contained in:
pablohashescobar
2023-02-14 20:08:04 +05:30
parent c9dce08842
commit b8c1305883
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
apiserver/plane/api/views/issue.py
View File

@@ -22,6 +22,7 @@ from plane.api.serializers import (
LabelSerializer, LabelSerializer,
IssueSerializer, IssueSerializer,
LabelSerializer, LabelSerializer,
IssueFlatSerializer,
) )
from plane.api.permissions import ( from plane.api.permissions import (
ProjectEntityPermission, ProjectEntityPermission,
@@ -579,7 +580,7 @@ class SubIssuesEndpoint(BaseAPIView):
parent_issue = Issue.objects.get(pk=issue_id) parent_issue = Issue.objects.get(pk=issue_id)
sub_issue_ids = request.data.get("sub_issue_ids", []) sub_issue_ids = request.data.get("sub_issue_ids", [])
if len(sub_issue_ids): if not len(sub_issue_ids):
return Response( return Response(
{"error": "Sub Issue IDs are required"}, {"error": "Sub Issue IDs are required"},
status=status.HTTP_400_BAD_REQUEST, status=status.HTTP_400_BAD_REQUEST,
@@ -590,12 +591,12 @@ class SubIssuesEndpoint(BaseAPIView):
for sub_issue in sub_issues: for sub_issue in sub_issues:
sub_issue.parent = parent_issue sub_issue.parent = parent_issue
updated_sub_issues = Issue.objects.bulk_update( _ = Issue.objects.bulk_update(sub_issues, ["parent"], batch_size=10)
sub_issues, ["parent"], batch_size=10
) updated_sub_issues = Issue.objects.filter(id__in=sub_issue_ids)
return Response( return Response(
IssueSerializer(updated_sub_issues, many=True).data, IssueFlatSerializer(updated_sub_issues, many=True).data,
status=status.HTTP_200_OK, status=status.HTTP_200_OK,
) )
except Issue.DoesNotExist: except Issue.DoesNotExist: